Use QGIS API to convert AMS datasource to dictionary #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbruy
force-pushed
the
refactor-datasource2dict
branch
from
22dc884 to
70f6af8
Compare
alexbruy
force-pushed
the
refactor-datasource2dict
branch
from
70f6af8 to
2460b95
Compare
Now datasource2dict handles parsing of all datasource types
|
@wlorenzetti I hope this does not break anything, I'm still learning the code and architecture. |
Don't worry Alex, CI is present :) |
versions < 3.42.1/3.40.5 See qgis/QGIS#60703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use QGIS API to convert data source string to Python dictionary.
Instead of relying on regular expressions, try to parse datasource string using provider-specific
decodeUri()method and if corresponding provider does not support it - fallback to useQgsDataSourceUriclass. Also removeddatasourcearcgis2dict()function as its functionality should be covered by updateddatasource2dict().Note that some tests will fail on QGIS <= 3.43 for now because of the minor bug in PostgreSQL data provider, there is an open PR to fix this qgis/QGIS#60703.
Fixes #276.