Prevent showing commit dialog when starting to edit a layer that is not in relation with last edited layer #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an doesn't in relation of last toolbox selected
volterra79
added a commit
to g3w-suite/g3w-admin
that referenced
this pull request
Jun 26, 2024
volterra79
added a commit
that referenced
this pull request
Jun 26, 2024
Raruto
changed the title
wlorenzetti
added a commit
to g3w-suite/g3w-admin
that referenced
this pull request
Jul 3, 2024
* ⬆️ Client g3w-suite/g3w-client#642 g3w-suite/g3w-client-plugin-editing#115 * ⬆️ Client g3w-suite/g3w-client@eb58ce0 * ⬆️ Client g3w-suite/g3w-client@c411b01 --------- Co-authored-by: Walter Lorenzetti <[email protected]>
wlorenzetti
pushed a commit
to g3w-suite/g3w-admin
that referenced
this pull request
Jul 6, 2024
* ⬆️ Client g3w-suite/g3w-client#642 g3w-suite/g3w-client-plugin-editing#115 * ⬆️ Client g3w-suite/g3w-client@eb58ce0 * ⬆️ Client g3w-suite/g3w-client@c411b01 * ⬆️ Client g3w-suite/g3w-client@afa5af6 * ⬆️ Client https://github.com/g3w-suite/g3w-client/releases/tag/v3.9.10 https://github.com/g3w-suite/g3w-client-plugin-editing/releases/tag/v3.7.9 --------- Co-authored-by: wlorenzetti <[email protected]>
volterra79
added a commit
to g3w-suite/g3w-admin
that referenced
this pull request
Jul 11, 2024
volterra79
added a commit
to g3w-suite/g3w-admin
that referenced
this pull request
Jul 12, 2024
Merged
volterra79
added a commit
that referenced
this pull request
Aug 6, 2024
…ot in relation with last edited layer (#116) * 🐛 Port #115 to v3.8.x * code format * move `toolboxidactivetool` into `Editing.vue` * 🐛 set features to [] in case of no features get * promisify + jsdoc for commit dirty * i18n + convert to async funcion: `toolbox.revert()` * attempt to fix revert * remove doubtful function: `revert()` * `indexOf` → `includes` * new constructor param: `ToolBox(layer, dependencies)` * 🐛 Commit dirty layer features * ✨ Zoom to constraint scale on map click * show `ol-zoom-in` cursor when `false == canEdit` * 🎨watch select and canEdit in one watch * add helper function: `getActiveTool` * 🐛 Use one watch only for check changes of control, selection and edit * console.log * getInteraction() * click on panel to fit zoom constraint * simplify watcher * prevent "clicktozoom" behavior on "start-editing" button * 🔥 Remove unused CopyFeaturesFromOtherProjectLayer.vue * missing cursor * ♻️ Move cursor scale constraint to _handleScaleConstraint method. Need to remove this.unwatches ? * Use setMouseCursor * remove console.log * fix zoom-in cursor * extract const * when stop toolbox, in case of scale constraint need to remove event handler on change:resolution * Fix show zoom in when not in editing * Fix show zoom on start * 3.9.0-alpha.0 * Change version to v3.9.0-alpha.0 --------- Co-authored-by: Raruto <[email protected]>
volterra79
added a commit
that referenced
this pull request
Aug 6, 2024
* Clean code - spaces * Clean code - spaces * Clean code - spaces and comments * Clean code - spaces and comments * Clean code - spaces * Clean code - spaces * Clean code - spaces * Update version info * Clean code - spaces * 🐛 Check if there is an active tool on toolbox * 🐛 Port #115 to v3.8.x * 🐛 set features to [] in case of no features get * 3.8.1 * Revert "3.8.1" This reverts commit 8859cb6. * 3.8.1-alpha.0 --------- Co-authored-by: Raruto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports: #116 to v3.7.x