Rotate pegman marker icon and google street view panorama accordingly #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add new listener: `google.maps.StreetViewPanorama#pov_changed` - refactor listener `google.maps.StreetviewPanorama#position_changed` (just a little bit of code clean up)
Raruto
commented
Feb 14, 2023
Comment on lines
+158
to
+166
| * @TODO compute intial heading evaluating it between the "openlayers" and "streetview" coordinates | ||
| */ | ||
| // this._panorama.setPov({ | ||
| // heading: google.maps.geometry.spherical.computeHeading(data.location.latLng, new google.maps.LatLng(this._clickLat, this._clickLng)), | ||
| // pitch: 0, | ||
| // zoom: 0 | ||
| // }); | ||
| } | ||
| }; |
There was a problem hiding this comment.
take a look at it before merging
Raruto
commented
Feb 14, 2023
Comment on lines
+203
to
+206
| /** | ||
| * @TODO really ugly, find out a simpler way to just update the `ol.style.Icon~rotation` value | ||
| */ | ||
| this.onPanoramaPositionChanged(); |
There was a problem hiding this comment.
take a look at it before merging
# Conflicts: # src/app/core/editing/history.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve end-user experience by rotating the marker arrow (on the map) in relation to what is currently displayed in the panorama container (streetview navigation).
Preview
Notable changes
google.maps.StreetViewPanorama#pov_changedgoogle.maps.StreetviewPanorama#position_changed(just a little bit of code clean up)whitetoyellow(pegman marker)Closes: #337
Supersedes: #338