Add support for showmarker=1 and iframetype=map urls parameters
#603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ker (0/1 - show marker map center) and iframetype (map -> only map without map controls). Move urls parameters check only when create view options on main map
Raruto
reviewed
Mar 26, 2024
Raruto
reviewed
Mar 26, 2024
Raruto
changed the title
showmarker=1 and iframetype=map urls parameters
Raruto
approved these changes
Mar 26, 2024
Raruto
approved these changes
Mar 27, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
…603) * Add center map marker svg * Rename icon marker * ✨ Transform zoomTo methods async. Introduce 2 new url params: showmarker (0/1 - show marker map center) and iframetype (map -> only map without map controls). Move urls parameters check only when create view options on main map * set default resolve promise * refactor `_setupViewer` (avoid temp `promise`) * refactor `_calculateViewOptions` (remove temp vars) * comment * remove function `_setUpDefaultLayers` * shorten * convert to async function: `zoomToExtent` * refactor function `highlightGeometry` (reduce nesting) * restore `zoom` and `highlight` * spacing * refactor functions: `zoomToFid` and `handleZoomToFeaturesUrlParameter` * allow zero values (`isNaN`) * fix `typeof` * other typeofs * `parseFloat` + `isNaN` instead of multiply * add 500ms to setTimeout --------- Co-authored-by: Raruto <[email protected]> (cherry picked from commit 8205b85)
volterra79
added a commit
that referenced
this pull request
Mar 27, 2024
…603) (#604) * Add center map marker svg * Rename icon marker * ✨ Transform zoomTo methods async. Introduce 2 new url params: showmarker (0/1 - show marker map center) and iframetype (map -> only map without map controls). Move urls parameters check only when create view options on main map * set default resolve promise * refactor `_setupViewer` (avoid temp `promise`) * refactor `_calculateViewOptions` (remove temp vars) * comment * remove function `_setUpDefaultLayers` * shorten * convert to async function: `zoomToExtent` * refactor function `highlightGeometry` (reduce nesting) * restore `zoom` and `highlight` * spacing * refactor functions: `zoomToFid` and `handleZoomToFeaturesUrlParameter` * allow zero values (`isNaN`) * fix `typeof` * other typeofs * `parseFloat` + `isNaN` instead of multiply * add 500ms to setTimeout --------- Co-authored-by: Raruto <[email protected]> (cherry picked from commit 8205b85) Co-authored-by: Francesco Boccacci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ex. ?showmarker=1
Ex: ?iframetype=map