Input Range from input is not valid when is not required and not value is set #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raruto
approved these changes
Sep 6, 2024
…nto issue_657 # Conflicts: # src/app/gui/inputs/service.js
…sefull maintain it to remember during changes
volterra79
added a commit
to g3w-suite/g3w-admin
that referenced
this pull request
Sep 13, 2024
volterra79
added a commit
to g3w-suite/g3w-admin
that referenced
this pull request
Sep 16, 2024
leolami
approved these changes
Sep 17, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
…e is set (#658) * 🐛 Fix validation of input not required * avoid nested `if-else` * 🐛 Fix validation of input not required and empty * Add conversion value of state value to compare with values from server * Comment * force add options values array in case validate.unique * Simplify checkbox * Fix validation of exlude_value fro this.state.validate.unique general * Change behavior of input unique widget * Set always empty values array in case if not provided by server configuration * Remove from current list of unique values, the old value * Editing add new value. No need to remove initial value. It could be usefull maintain it to remember during changes --------- Co-authored-by: Raruto <[email protected]> (cherry picked from commit 67fc2fe)
volterra79
added a commit
that referenced
this pull request
Sep 17, 2024
…e is set (#658) (#661) * 🐛 Fix validation of input not required * avoid nested `if-else` * 🐛 Fix validation of input not required and empty * Add conversion value of state value to compare with values from server * Comment * force add options values array in case validate.unique * Simplify checkbox * Fix validation of exlude_value fro this.state.validate.unique general * Change behavior of input unique widget * Set always empty values array in case if not provided by server configuration * Remove from current list of unique values, the old value * Editing add new value. No need to remove initial value. It could be usefull maintain it to remember during changes --------- Co-authored-by: Raruto <[email protected]> (cherry picked from commit 67fc2fe) Co-authored-by: Francesco Boccacci <[email protected]>
volterra79
added a commit
that referenced
this pull request
Sep 26, 2024
…rol (#647) * Remove duplicate added by merge * Wrong reference due merge * Replace d.resolve with resolve due merge * use GUI.getService * remove unusued stuff * wrong context * replace: `state.components` → `GUI.getComponent()` * Use reactive state vue. Need to fix showPanel on sidebar * Remove push * use import { $promisify, promisify } from 'utils/promisify' instead $.Deferred * use import { $promisify } from 'utils/promisify' instead $.Deferred * use import { $promisify } from 'utils/promisify' instead $.Deferred * use import { $promisify } from 'utils/promisify' instead $.Deferred * use import { $promisify } from 'utils/promisify' instead $.Deferred * use import { $promisify } from 'utils/promisify' instead $.Deferred * use import { $promisify } from 'utils/promisify' instead $.Deferred * use import { $promisify } from 'utils/promisify' instead $.Deferred * Fix double get data from querybypolygon async nature of GUI.closeContent * use $promisify instead of $.Deferred * use $promisify instead of $.Deferred * use $promisify instead of $.Deferred * use $promisify instead of $.Deferred * use $promisify instead of $.Deferred * use $promisify instead of $.Deferred * Comment and return $.Deferred * 🐛 Mispelling variable name * Clean code - space * 🐛 Use Promise.resolve instead resolve of $promisify * 💡 Comments * 💡 Comments * Clean code - Comments and readability * Clean code - readability * 🐛 call panel show twice. Remove panel.show(). It is called automatically due opts.show = true * Return panel if usefully * Clean code - readability * Clean code - readability * Clean code - readability * Clean code - readability * Clean code - readability * Clean code - readability * Clean code - readability * Clean code - readability * Clean code - readability * Clean code - readability * Clean code - readability * Replace $.get with XHR.get * 🐛 Pass config and opts to TableLayer parent class * Clean code - Readability * Clean code - Readability * add check on querybycircle onselectLayer event * Remove config.js. Move content on APP_CONFIG constant * Clean code - Readability * Remove action button class * Clean code - Readability * 💄 Change style * use inludes instead indexOf * Clean code - Readability * Replace -1 == indexOf with .includes * Clean code - spaces * Clean code - spaces * Clean code - spaces * Clean code - spaces and replace with includes * 🐛 spite.state.slip. Wrong refactoring * 🐛 Wrong refactoring. Need to create getDefaultExpression and getFilterExpression utils * Comments * Fix an isse on .clear collection * Move code in one place * Fix in case of missing source map file * 🐛 add immediate attribute to watch otherwise for v-select2 createSelect2 it called twice at creation * Bind multiple boolean value * Add forec options to delete plugin.js.map source map file * 🐛 Fix wrong variable name * Clean code - Change variable name * race condition: `GUI.closeContent()` * shorter function names * avoid `new promise()` + remove dead code * avoid `new Promise()` * ✨ Add text on input form fields that belong to a relation * remove dead code * move `getTimeoutPromise()` into providers factory * Remove duplicate method closeLayerMenu * 🐛 Move this.last_map_control = on mounted hook. Move from created beacause when open attribute table twice without close content, new create hook method is called befoare beforeDestroy hook of previous Table.vue component * 🌐 Change translation * Move below input label * remove unused utils * explicit `promise.race` (promise with timeout) * 🐛 Fix bind reference * code cleanup * remove abstract class: `BaseService` * 🐛 Back to name query beacause it used by project querymultilayers attribute * Use querybypolygon fro alla querybypolygon','querybydrawpolygon', 'querybycircle' query control to check if isQueryMultiLayer * Fix parser application/vnd.ogc.gml fro multilayer * Simplify code * css * move `currentoutputplaces` into GUI * refactor multilayers logic * move `getQueryLayersPromisesByCoordinates` into data service * restore `excludeSelected` param * remove class: `RelationsService` * ♻️ parser application/vnd.ogc.gml * add `persistent` option * convert `<layerspositions>` into a plain `<select>` within `MapAddLayer.vue` * 🐛 Fix single query for layers * Uniform getQueryLayersPromisesByGeometry and getQueryLayersPromisesByCoordinates with same resposte handler * remove `search_endpoint` * avoid `new Promise` * simplify promises * jsdoc * simplify `GUI.outputDataPlace` * Refactor application/vnd.ogc.gml parser * 🐛 check if features have geometries * remove constant: `APP_CONFIG` * Set right features fid for multi layer wms response * remove `Filter` and `Expression` classes * console.trace * ♻️ getGeometryAndExtentFromFeatures method * highLightLayerFeatures also when result layer has one feature * Clean code - Readability * 🐛 Missing await * Add comment * 🐛 Fix loading query result content when multi request are done * slim down class: `ApplicationService` * unusued imports * Clean code * remove browser prefix * fix page flash * Add loading type String to bar-loader * BACKOMP: `ApplicationService.isIframe()` * remove: `ProjectsRegistry.init(initConfig)` and `ApiService.init(initConfig)` * remove class: `BarStack` * remove unusued css * console.trace * remove unusued css * refactor `MetadataProject.vue` * Update index.prod.js * slim down class: `ProjectsRegistry` * extract files from `src/app/core` folder * remove unusued utils * missing service * remove `g3wsdk.core.layer.geometry` * remove unusued utils * convert `$.ajax` requests to `fetch` API * simplify code * simplify code * remove class: `ProjectsRegistry` * slim down: `createMeasureTooltip` * convert to ES6 exports * 🐛 Fix XHR.get using fetch. Use params for streetview call api * Add console.warn * Remove $.fileDownload from fileDownload suing fetch * Simplify fileDownload * Simplify fileDownload * #660 (comment) * Merge #658 * Remove merge file * remove `jquery.fileDownload.js` * try .. finally * Merge fix * Mispelling merge options * Space * remove `console.warn` * slim down `FeaturesStore` * native promise * invalid variable name * missing id * console.log * remove `g3wsdk.core.geoutils.getFeaturesFromResponseVectorApi` * Rempce lodash dependency * Replace _.trim() lodash dependency with trim() * remove: `utils/splitFeatures.js` * Update splitFeature.js * Delete splitGeometryLine.js * Update createRelationsUrl.js * delete `isSameBaseGeometryType.js` * remove utils: `getAllPolygonGeometryTypes`, `getAllPointGeometryTypes`, `getAllLineGeometryTypes` * backcomp * remove: 'utils/dissolve.js' * Update distance.js * Update sanitizeFidFeature.js * move `QgsFilterToken` into `Layer` class * Comment * Need to add null check beacuse we substitute _.trim() with trim() * Need to add null check because we substitute _.trim() with trim() * remove: `utils/validators/index.js` * remove: `utils/getMetersFromDegrees.js` * remove: `multiGeometryToSingleGeometries`, `singleGeometriesToMultiGeometry` * 🐛 select2 dropdownParent:$('.g3w-search-form:visible') * 🐛 Create gey map print area only if the template is not atlas and has at least one maps * remove `utils/print` * ✨ Show loading content during load image or pdf * remove `utils/isSingleGeometry.js` * remove `capitalize_first_letter` * slim down: `store/catalog-layers` and `store/plugins` * same as: 6d0c94e * Remove merge file * space * 💄 css tool and sidebar-item icon space * Comment * Clean code - simplify * ✨ Add Application.gui.sidebar.open attribute to show tooltip when sidebar is collapsed * 💄 show arrow up or arrow down when map theme is open or closed * 🐛 using feature variable for ol feature and feature * 💄 change button toggled color and background * Remove merge wrong empty files * 💄 Show sidebar item tooltip when sidebar is collapsed * move: `src/assets/style/less/app.less` into `src/assets/app.css` * Delete app.less * wrong merge * move v-tooltip to parent container * Show tooltip on sidebar item only when sidebar is collapsed * Remove skin color to v-t-tooltip * Dynamic tooltip on tool * update css * useful: `:current-tooltip` * 🐛 In case of layer title with strange character, fix show title on context * left align map control tooltips * 🐛 Hide tooltip when current-tooltip is null or empty * 🐛 :Bug: Show error message in case of error when zoom to layer. It can happen if strange bbox is set by server to layer * remove `ApiService` * Clena code - space and console.log removed * 🐛 Change layer position * 🐛 emit event change position instead change position pros directly * remove `directives/v-selected-first.js` * remove `directives/v-plugins.js` * remove `directives/v-online.js` * simplify `v-disabled` * 🐛 return state * Clean code - spaces * Clean code - spaces * Clean code - readability * 🐛 Shor layers result sort by TOC layers order * 🐛 Missing ARCGISMAPSERVER base layer * remove `v-t-placeholder` --------- Co-authored-by: Raruto <[email protected]>
wlorenzetti
added a commit
to g3w-suite/g3w-admin
that referenced
this pull request
Sep 27, 2024
* ⬆️ Bump g3w-client v3.10.3, g3w-client-plugin-editing v3.8.3 g3w-suite/g3w-client#658 g3w-suite/g3w-client-plugin-editing#127 * ⬆️ Client Pre g3w-client v3.10.3 g3w-suite/g3w-client-plugin-editing#128 * ⬆️ Client https://github.com/g3w-suite/g3w-client/releases/tag/v3.10.3 https://github.com/g3w-suite/g3w-client-plugin-editing/releases/tag/v3.8.3 --------- Co-authored-by: Walter Lorenzetti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #657