Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Download layer features from search with pagination #743

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

volterra79
Copy link
Member

If we set a search with pagination

Screenshot_20250225_123221

and we try to download all feature from search belong to layer

Screenshot_20250225_123347

we get only visible features

Screenshot_20250225_123543

and not all features from search (10 to 17)

After

Screenshot_20250225_123658

we get all 17 features

@volterra79 volterra79 added bug Something isn't working backport to v3.11.x labels Feb 25, 2025
@volterra79 volterra79 added this to the v5.0 milestone Feb 25, 2025
@volterra79 volterra79 requested review from leolami and Raruto February 25, 2025 11:37
@volterra79 volterra79 self-assigned this Feb 25, 2025
Copy link
Collaborator

@Raruto Raruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volterra79

  1. this is not bug, that term should be used sparingly! (ie. this a ux change or a feature request)
  2. let fronted user decide whether should be preferred behavior (eg. add checkbox/button for: download all / only visible)

@volterra79
Copy link
Member Author

@volterra79

  1. this is not bug, that term should be used sparingly! (ie. this a ux change or a feature request)
  2. let fronted user decide whether should be preferred behavior (eg. add checkbox/button for: download all / only visible)

@Raruto i think that:
1 - is a bug. Before introduce pagination, user, when clicked on download button , expects all feature of search belong to layer.
2 - @leolami what do you think about?

@leolami
Copy link
Member

leolami commented Feb 25, 2025

@Raruto

For now let's fix it by allowing the download of all layers without the visible/all option

Then, maybe, we'll see about proposing it as a feature in 3.10

@Raruto
Copy link
Collaborator

Raruto commented Feb 25, 2025

1 - is a bug. Before introduce pagination, user, when clicked on download button , expects all feature of search belong to layer.

@volterra79 Ok, I get the clue.

But please, always add a "short summary" of why you think it's a bug on new issues/PRs you create.

Without that info, the "before/after" section is hard to understand (ie. both the modification and the reason must be understood).

@volterra79 volterra79 merged commit 4315210 into dev Feb 25, 2025
@volterra79 volterra79 deleted the downoad_feature_search_pagination branch February 25, 2025 13:45
github-actions bot pushed a commit that referenced this pull request Feb 25, 2025
* 🐛 Download layer features from search

* jsdoc

* jsdoc

---------

Co-authored-by: Raruto <[email protected]>
(cherry picked from commit 4315210)
volterra79 added a commit that referenced this pull request Feb 25, 2025
* 🐛 Download layer features from search

* jsdoc

* jsdoc

---------

Co-authored-by: Raruto <[email protected]>
(cherry picked from commit 4315210)

Co-authored-by: Francesco Boccacci <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to v3.11.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants