-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Download layer features from search with pagination #743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- this is not
bug
, that term should be used sparingly! (ie. this aux
change or afeature
request) - let fronted user decide whether should be preferred behavior (eg. add checkbox/button for: download all / only visible)
@Raruto i think that: |
For now let's fix it by allowing the download of all layers without the visible/all option Then, maybe, we'll see about proposing it as a feature in 3.10 |
@volterra79 Ok, I get the clue. But please, always add a "short summary" of why you think it's a bug on new issues/PRs you create. Without that info, the "before/after" section is hard to understand (ie. both the modification and the reason must be understood). |
* 🐛 Download layer features from search * jsdoc * jsdoc --------- Co-authored-by: Raruto <[email protected]> (cherry picked from commit 4315210)
* 🐛 Download layer features from search * jsdoc * jsdoc --------- Co-authored-by: Raruto <[email protected]> (cherry picked from commit 4315210) Co-authored-by: Francesco Boccacci <[email protected]>
If we set a search with pagination
and we try to download all feature from search belong to layer
we get only visible features
and not all features from search (10 to 17)
After
we get all 17 features