Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fmt to fix MSVC C4996 warning #3020

Closed
wants to merge 1 commit into from
Closed

Update fmt to fix MSVC C4996 warning #3020

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 23, 2024

This PR updates the fmt library to resolve the MSVC C4996 deprecation warning, as highlighted in issue #3540 from the fmtlib repo.

Reference: Issue #2987

@gabime
Copy link
Owner

gabime commented Feb 23, 2024

Thanks. Please submit the PR to the fmtlib repo insread.

@gabime gabime closed this Feb 23, 2024
@ghost
Copy link
Author

ghost commented Sep 2, 2024

I apologize for not explaining my intention clearly. The purpose of this PR was to update the embedded fmt library within spdlog to its latest version, which resolves the MSVC C4996 warning. I wasn't attempting to modify the fmt library itself, but rather to update spdlog's bundled version of fmt. This update aims to address the issue mentioned in spdlog#2987. I'm sorry for any confusion this may have caused.

I'm glad to see that the update seems to be working well now and the warning issue has been resolved. This is the outcome I was hoping for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant