Add IE touch support via pointer events #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this still work on android? |
|
It still works in Chrome before and after my change which is also webkit/touch events. I don't have an android device with which to test, but I expect it to behave the same. I have my fork running on the following URI if someone has an android device and wants to test touch: http://david-risney.github.io/2048/ |
|
I'll need to get a 👍 from someone using android before I can merge this, because I also have no device to test with. |
gabrielecirulli
added a commit
that referenced
this pull request
Mar 23, 2014
|
Closing this because I merged another similar PR. Should work fine on IE now. Thanks, though! |
ml4den
pushed a commit
to ml4den/2048
that referenced
this pull request
Sep 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching from hammer to custom touch code lost pointer event support which is required for touch in IE and Phone IE. This change adds in pointer event support to the custom touch code and adds the two CSS changes necessary for IE to get the touch events.