refactor: small improvement to some type cases where any was required

gabrielguerrero · Apr 22, 2024 · d690a48 · d690a48
1 parent dc2858d
commit d690a48
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 10 deletions.
diff --git a/libs/ngrx-traits/signals/src/lib/with-entities-filter/with-entities-local-filter.ts b/libs/ngrx-traits/signals/src/lib/with-entities-filter/with-entities-local-filter.ts
@@ -139,10 +139,13 @@ export function withEntitiesLocalFilter<
   entity?: Entity;
   collection?: Collection;
 }): SignalStoreFeature<
-  // TODO: the problem seems be with the state pro, when set to any
-  //  it works but is it has a namedstate it doesnt
+  // TODO: we have a problem  with the state property, when set to string
+  // it works but is it has a Collection, some methods are not generated, it seems
+  // to only be accessible using store['filterEntities']
+  // the workaround doesn't cause any issues, because the signals prop does work and still
+  // gives the right error requiring withEntities to be used
   {
-    state: NamedEntityState<Entity, any>;
+    state: NamedEntityState<Entity, string>;
     signals: NamedEntitySignals<Entity, Collection>;
     methods: {};
   },

diff --git a/libs/ngrx-traits/signals/src/lib/with-entities-pagination/with-entities-local-pagination.ts b/libs/ngrx-traits/signals/src/lib/with-entities-pagination/with-entities-local-pagination.ts
@@ -120,7 +120,7 @@ export function withEntitiesLocalPagination<
   collection?: Collection;
 }): SignalStoreFeature<
   {
-    state: NamedEntityState<Entity, any>; // if put Collection the some props get lost and can only be access ['prop'] weird bug
+    state: NamedEntityState<Entity, string>; // if put Collection the some props get lost and can only be access ['prop'] weird bug
     signals: NamedEntitySignals<Entity, Collection>;
     methods: {};
   },

diff --git a/libs/ngrx-traits/signals/src/lib/with-entities-pagination/with-entities-remote-pagination.ts b/libs/ngrx-traits/signals/src/lib/with-entities-pagination/with-entities-remote-pagination.ts
@@ -247,7 +247,7 @@ export function withEntitiesRemotePagination<
   collection?: Collection;
 }): SignalStoreFeature<
   {
-    state: NamedEntityState<Entity, any>; // if put Collection the some props get lost and can only be access ['prop'] weird bug
+    state: NamedEntityState<Entity, string>; // if put Collection the some props get lost and can only be access ['prop'] weird bug
     signals: NamedEntitySignals<Entity, Collection> &
       NamedCallStatusComputed<Collection>;
     methods: NamedCallStatusMethods<Collection>;

diff --git a/...traits/signals/src/lib/with-entities-pagination/with-entities-remote-scroll-pagination.ts b/...traits/signals/src/lib/with-entities-pagination/with-entities-remote-scroll-pagination.ts
@@ -260,7 +260,7 @@ export function withEntitiesRemoteScrollPagination<
   collection?: Collection;
 }): SignalStoreFeature<
   {
-    state: NamedEntityState<Entity, any>; // if put Collection the some props get lost and can only be access ['prop'] weird bug
+    state: NamedEntityState<Entity, string>; // if put Collection the some props get lost and can only be access ['prop'] weird bug
     signals: NamedEntitySignals<Entity, Collection> &
       NamedCallStatusComputed<Collection>;
     methods: NamedCallStatusMethods<Collection>;

diff --git a/libs/ngrx-traits/signals/src/lib/with-entities-sort/with-entities-local-sort.ts b/libs/ngrx-traits/signals/src/lib/with-entities-sort/with-entities-local-sort.ts
@@ -108,10 +108,13 @@ export function withEntitiesLocalSort<
   entity?: Entity;
   collection?: Collection;
 }): SignalStoreFeature<
-  // TODO: the problem seems be with the state pro, when set to empty
-  //  it works but is it has a namedstate it doesnt
+  // TODO: we have a problem  with the state property, when set to string
+  // it works but is it has a Collection, some methods are not generated, it seems
+  // to only be accessible using store['filterEntities']
+  // the workaround doesn't cause any issues, because the signals prop does work and still
+  // gives the right error requiring withEntities to be used
   {
-    state: NamedEntityState<Entity, any>;
+    state: NamedEntityState<Entity, string>;
     signals: NamedEntitySignals<Entity, Collection>;
     methods: {};
   },

diff --git a/libs/ngrx-traits/signals/src/lib/with-entities-sort/with-entities-remote-sort.ts b/libs/ngrx-traits/signals/src/lib/with-entities-sort/with-entities-remote-sort.ts
@@ -204,7 +204,7 @@ export function withEntitiesRemoteSort<
   collection?: Collection;
 }): SignalStoreFeature<
   {
-    state: NamedEntityState<Entity, any>;
+    state: NamedEntityState<Entity, string>;
     signals: NamedEntitySignals<Entity, Collection>;
     methods: NamedCallStatusMethods<Collection>;
   },