Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withEntitiesLoading mapPipe= switchMap not working #162

Closed
gabrielguerrero opened this issue Feb 7, 2025 · 2 comments · Fixed by #164
Closed

withEntitiesLoading mapPipe= switchMap not working #162

gabrielguerrero opened this issue Feb 7, 2025 · 2 comments · Fixed by #164
Labels

Comments

@gabrielguerrero
Copy link
Owner

withEntitiesLoading mapPipe= switchMap is not working, meaning when the setLoading it triggers the fetchEntities but if setLoading is called again and the fetch Call has not been finish , it will not cancel the previous call and do another, like it should be with switchMap, but this is been hiding because this is normally is used in conjunction with withEntitiesRemoteFilter which debounces the call giving the impression the last call is the one that wins, but after the debounce if the fetch call starts and the filter is called again it wont cancel the previous call. The problem is caused because withEntitiesLoading was using a toObservable of isLoading() computed signal, which once it sets to true it will not emit true again when setLoading is called and was already true.
This pr is a small refactor to use emit events when the setLoading is called and listen to the events to trigger the fetch entities, which will now be be using an rxMethod can will use the switchMap or other kind of map pipe selected

@gabrielguerrero gabrielguerrero added the bug Something isn't working label Feb 7, 2025
gabrielguerrero pushed a commit that referenced this issue Feb 7, 2025
This small refactor fixes a bug causing the swithMap impl not cancel request when new setLoading are
trigger.

Fixes #162
gabrielguerrero pushed a commit that referenced this issue Feb 7, 2025
This small refactor fixes a bug causing the swithMap impl not cancel request when new setLoading are
trigger.

Fixes #162
Copy link

github-actions bot commented Feb 7, 2025

🎉 This issue has been resolved in version 18.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

gabrielguerrero pushed a commit that referenced this issue Feb 8, 2025
This small refactor fixes a bug causing the swithMap impl not cancel request when new setLoading are
trigger.

Fixes #162
Copy link

github-actions bot commented Feb 8, 2025

🎉 This issue has been resolved in version 19.0.0-beta.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant