Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/several fixes #49

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Fix/several fixes #49

merged 1 commit into from
Apr 5, 2024

Conversation

gabrielguerrero
Copy link
Owner

- Ensure withEntitiesRemote Filter Sort and Pagination depend on CallStateMethods
- Remove comments and console.log
- Ensure some imports use type imports
- New withEntitiesLocalFilter implementation that doesn't override entities computed, and doesn't have problem with pagination trait being before the filter
- Fixed bug in withCalls not storing error and signal to read result
- withCalls prop is now [callName]Result instead of [callName]Data

- Ensure withEntitiesRemote Filter Sort and Pagination depend on CallStateMethods
- Remove comments and console.log
- Ensure some imports use type imports
- New withEntitiesLocalFilter implementation that doesnt override entities computed, and doesnt have problem with pagination trait been before or after
- Fixed bug in withCalls not storing error and signal to read result
- withCalls prop is now [callName]Result instead of [callName]Data
@gabrielguerrero gabrielguerrero changed the base branch from main to beta April 5, 2024 15:11
@gabrielguerrero gabrielguerrero merged commit e7c90a8 into beta Apr 5, 2024
2 checks passed
Copy link

github-actions bot commented Apr 5, 2024

🎉 This PR is included in version 17.1.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant