-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new module recommendationsBySymbol #28
Conversation
@gadicc feel free to have a look when you have time! :) |
@pudgereyem! This is phenomenal work!! You really checked all the boxes on this one... styling, approach, docs, tests... it really is such a pleasure for a project maintainer when contributors fit in so well. Thanks also for getting up to date on all the latest conventions and noticing the new
Anyway, thanks again for this amazing work! Not sure how long you spent on this but it's super appreciated 😀 Keep up the awesome work 🙌 |
@gadicc ah, thanks! It was super simple to create the new module. Thanks to the great architecture 💯 |
@gadicc please have a look now, I've addressed your two comments above. |
Legend! This is really great, @pudgereyem! Pleasure working with you 😁 |
# [1.7.0](v1.6.0...v1.7.0) (2021-02-10) ### Bug Fixes * **index:** uhhhh s/_options/_opts/ like it's called everywhere else ([4492993](4492993)) * **moduleExec:** pass correct object to validation ([#27](#27)) ([8b0f9c7](8b0f9c7)) * **modules:** change overloading order specificy (fixes [#21](#21)) ([1806e61](1806e61)) * **quote:** extend marketState property ([0c36a60](0c36a60)) * **quote:** interface fixes, 10am UTC tests ([#35](#35)) ([1c256c7](1c256c7)) ### Features * new module recommendationsBySymbol ([#28](#28)) ([b467acb](b467acb))
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR adds a new module
recommendationsBySymbol
that retrieves "Similar instruments" to the one's you pass.How it's used on Yahoo Finance
When you view a specific symbol on Yahoo Finance they will show a widget on the right hand side; "People also watch" - which the user might be interested in. Below you can see what is shown when browsing Activision Blizzard ($ATVI).
About the endpoint
https://query2.finance.yahoo.com/v6/finance/recommendationsbysymbol/${symbols}
The response
The response back from Yahoo looks like this:
Changes
recommendationsBySymbol
recommendationsBySymbol
Example usage
Tests