Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify TypeScript configuration (updated) #1028

Merged
merged 3 commits into from
Aug 23, 2018
Merged

Simplify TypeScript configuration (updated) #1028

merged 3 commits into from
Aug 23, 2018

Conversation

Akuukis
Copy link
Contributor

@Akuukis Akuukis commented Jul 2, 2018

Quick work:

  • took Simplify TypeScript configuration #996 as a base for working typescript example,
  • upgraded from Webpack 3 to Webpack 4 and fixed configs,
  • upgraded other dependencies to current newest,
  • locked (remove ^) babel dependencies because it's still in beta,
  • rebased to new master,
  • add support for async & await syntax (EDIT: amended later),
  • tested and still working, faster than ever 🎉

Though I should share this. Thanks @lostfictions for heavy lifting!

@codecov-io
Copy link

codecov-io commented Jul 2, 2018

Codecov Report

Merging #1028 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1028   +/-   ##
=======================================
  Coverage   86.54%   86.54%           
=======================================
  Files          31       31           
  Lines         825      825           
  Branches      193      193           
=======================================
  Hits          714      714           
  Misses         92       92           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb748b...4a0830c. Read the comment docs.

@theKashey
Copy link
Collaborator

Looking great, but many people will refuse to use beta babel 7.
Probably one should leave some message about it, as long default package install will bring babel 6.

@Akuukis
Copy link
Contributor Author

Akuukis commented Jul 2, 2018

Makes sense. Should we add warning to README and merge, or leave this PR until babel 7 becomes stable?

@theKashey
Copy link
Collaborator

I have no idea when it will be done, so lets try just some notes in README

@Akuukis
Copy link
Contributor Author

Akuukis commented Jul 4, 2018

@theKashey are we good to proceed?

@theKashey
Copy link
Collaborator

All good, sorry just busy a bit in real world.

@theKashey
Copy link
Collaborator

I've found that some TS people do not like babel. They could be ok-ish to add babel as a webpack loader, but dont want to replace TS by babel as a whole.
Let me move old readme to a separate file, and point it for all non-babel-7 customers.

@theKashey theKashey mentioned this pull request Aug 19, 2018
@theKashey theKashey merged commit 6d3a30e into gaearon:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants