-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby support #148
Ruby support #148
Conversation
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
=========================================
- Coverage 65.84% 65.8% -0.04%
=========================================
Files 25 27 +2
Lines 2219 2354 +135
=========================================
+ Hits 1461 1549 +88
- Misses 589 618 +29
- Partials 169 187 +18
Continue to review full report at Codecov.
|
@Skarlso This ready for review. Documentation: gaia-pipeline/docs#9 |
@michelvocks Ack. I'll give this a spin today. :) |
@michelvocks is the go.mod file update intentional? |
@@ -13,7 +13,7 @@ import ( | |||
"github.com/gaia-pipeline/gaia" | |||
"github.com/gaia-pipeline/gaia/security" | |||
"github.com/gaia-pipeline/gaia/workers/scheduler" | |||
"github.com/gaia-pipeline/protobuf" | |||
proto "github.com/gaia-pipeline/protobuf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh? :O
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been auto corrected by goimports
. Shouldn't be a problem in my opinion.
Nope. No clue what is going on there. It has been magically added by go modules. |
@Skarlso I think the problem is golang/go#27643 I didn't know that |
I played around with this yesterday for a while. Looks good. I had some initial trouble getting bundler to work. I wonder if we should add --vendor into the doc. But I guess however is using Ruby probably already knows these tricks. I have one last go on the code today then it's good to merge. |
@Skarlso I've implemented the fix and added documentation for the special constraints. |
@michelvocks Do you need the name thingy for this in this? Or can we close this? It should be working. :) |
@Skarlso It's implemented. That is what I meant with my last reply. 😄 |
@michelvocks Haha yes. I'm an idiot. Sorry. :) Go ahead. :) |
Fixes #140