Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby support #148

Merged
merged 12 commits into from
Jan 28, 2019
Merged

Ruby support #148

merged 12 commits into from
Jan 28, 2019

Conversation

michelvocks
Copy link
Member

Fixes #140

@michelvocks michelvocks added the Needs Work The PR still requires some work from the submitter. label Jan 11, 2019
@michelvocks michelvocks self-assigned this Jan 11, 2019
@codecov-io
Copy link

codecov-io commented Jan 11, 2019

Codecov Report

Merging #148 into master will decrease coverage by 0.03%.
The diff coverage is 67.28%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #148      +/-   ##
=========================================
- Coverage   65.84%   65.8%   -0.04%     
=========================================
  Files          25      27       +2     
  Lines        2219    2354     +135     
=========================================
+ Hits         1461    1549      +88     
- Misses        589     618      +29     
- Partials      169     187      +18
Impacted Files Coverage Δ
plugin/plugin.go 66.93% <ø> (ø) ⬆️
workers/scheduler/scheduler.go 68.54% <ø> (-1.67%) ⬇️
workers/pipeline/ticker.go 36.5% <0%> (-0.59%) ⬇️
workers/pipeline/pipeline.go 95.38% <100%> (+2.47%) ⬆️
workers/pipeline/update_pipeline.go 52.5% <47.05%> (-4.03%) ⬇️
workers/pipeline/build_ruby.go 67.08% <67.08%> (ø)
workers/scheduler/create_cmd.go 73.77% <73.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a95a11...5ceebcc. Read the comment docs.

@michelvocks michelvocks added Ready To Merge PR is ready to be merged into master and removed Needs Work The PR still requires some work from the submitter. labels Jan 18, 2019
@michelvocks michelvocks requested a review from Skarlso January 18, 2019 17:25
@michelvocks
Copy link
Member Author

@Skarlso This ready for review.

Documentation: gaia-pipeline/docs#9
Ruby example pipeline: https://github.com/gaia-pipeline/ruby-example

@michelvocks michelvocks changed the title [WIP] Ruby support Ruby support Jan 18, 2019
@Skarlso
Copy link
Member

Skarlso commented Jan 19, 2019

@michelvocks Ack. I'll give this a spin today. :)

@Skarlso
Copy link
Member

Skarlso commented Jan 19, 2019

@michelvocks is the go.mod file update intentional?

@@ -13,7 +13,7 @@ import (
"github.com/gaia-pipeline/gaia"
"github.com/gaia-pipeline/gaia/security"
"github.com/gaia-pipeline/gaia/workers/scheduler"
"github.com/gaia-pipeline/protobuf"
proto "github.com/gaia-pipeline/protobuf"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh? :O

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been auto corrected by goimports. Shouldn't be a problem in my opinion.

@michelvocks
Copy link
Member Author

@michelvocks is the go.mod file update intentional?

Nope. No clue what is going on there. It has been magically added by go modules.

@michelvocks
Copy link
Member Author

@Skarlso I think the problem is golang/go#27643

I didn't know that go get will force go mod to automatically add it as dependency.
I've removed all indirect dependencies.

@Skarlso
Copy link
Member

Skarlso commented Jan 20, 2019

I played around with this yesterday for a while. Looks good. I had some initial trouble getting bundler to work. I wonder if we should add --vendor into the doc. But I guess however is using Ruby probably already knows these tricks.

I have one last go on the code today then it's good to merge.

@michelvocks
Copy link
Member Author

@Skarlso I've implemented the fix and added documentation for the special constraints.

@Skarlso
Copy link
Member

Skarlso commented Jan 25, 2019

@michelvocks Do you need the name thingy for this in this? Or can we close this? It should be working. :)

@michelvocks
Copy link
Member Author

@michelvocks Do you need the name thingy for this in this? Or can we close this? It should be working. :)

@Skarlso It's implemented. That is what I meant with my last reply. 😄
In my opinion this is ready for merge if you agree?

@Skarlso
Copy link
Member

Skarlso commented Jan 28, 2019

@michelvocks Haha yes. I'm an idiot. Sorry. :) Go ahead. :)

@michelvocks michelvocks merged commit 757d72d into gaia-pipeline:master Jan 28, 2019
@michelvocks michelvocks deleted the ruby_support branch January 28, 2019 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge PR is ready to be merged into master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants