Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed possible nil error on flag parse in case there are no parameters provided for the binary #209

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Fixed possible nil error on flag parse in case there are no parameters provided for the binary #209

merged 1 commit into from
Sep 4, 2019

Conversation

Skarlso
Copy link
Member

@Skarlso Skarlso commented Sep 4, 2019

Closes #207

@Skarlso Skarlso added Ready To Merge PR is ready to be merged into master needs review labels Sep 4, 2019
@Skarlso Skarlso requested a review from michelvocks September 4, 2019 10:59
@codecov-io
Copy link

Codecov Report

Merging #209 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #209   +/-   ##
=======================================
  Coverage   62.18%   62.18%           
=======================================
  Files          49       49           
  Lines        4046     4046           
=======================================
  Hits         2516     2516           
  Misses       1116     1116           
  Partials      414      414

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32bf82c...e8a44c5. Read the comment docs.

michelvocks
michelvocks approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@michelvocks michelvocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Skarlso Skarlso merged commit c68f7c1 into gaia-pipeline:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelvocks michelvocks michelvocks approved these changes

Assignees
No one assigned
Labels
needs review Ready To Merge PR is ready to be merged into master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsing the flag can end up in a nil pointer if err == nil
3 participants
@Skarlso @codecov-io @michelvocks