Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline details #217

Merged
merged 2 commits into from
Oct 8, 2019

Conversation

Shivakishore14
Copy link
Contributor

Resolves #170
Added the pipeline details table in the pipeline details view page.

Here is a screenshot
image

Let me know if this is good.

@codecov-io
Copy link

codecov-io commented Oct 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@4c6678f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #217   +/-   ##
========================================
  Coverage          ?   62.1%           
========================================
  Files             ?      49           
  Lines             ?    4059           
  Branches          ?       0           
========================================
  Hits              ?    2521           
  Misses            ?    1124           
  Partials          ?     414

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c6678f...0ac1710. Read the comment docs.

@Skarlso
Copy link
Member

Skarlso commented Oct 6, 2019

Hi @Shivakishore14! First of all, thank you very much for your contribution! Second, can you show as well where this is triggered from and how that looks like?

Cheers!

@michelvocks
Copy link
Member

Hi @Shivakishore14,

this looks very good! Thank you for your contribution!

Only a very tiny change I would like to see is the underlined space between the last-run-number and the "[success]" output in the "Last Run" column. It looks a bit cleaner if the space char is not underlined.

Otherwise, it looks great!

Cheers,
Michel

@Shivakishore14
Copy link
Contributor Author

@michelvocks yes, I have fixed that now.

@Skarlso I have added a new table to detail.vue page (as shown in the screenshot above), The data is populated from the pipeline and pipelineRun service calls which were already present in the page.

@Skarlso
Copy link
Member

Skarlso commented Oct 7, 2019

Oh duh. I thought it's a different view. Appologies. :D

Copy link
Member

@michelvocks michelvocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot ❤️

@michelvocks michelvocks merged commit 0327269 into gaia-pipeline:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a pipeline details view
4 participants