Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New security package introduced #55

Merged
merged 2 commits into from
Jul 23, 2018

Conversation

michelvocks
Copy link
Member

ping @Skarlso

@michelvocks michelvocks self-assigned this Jul 23, 2018
@codecov-io
Copy link

codecov-io commented Jul 23, 2018

Codecov Report

Merging #55 into master will increase coverage by 2.07%.
The diff coverage is 79.74%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #55      +/-   ##
=========================================
+ Coverage   50.43%   52.5%   +2.07%     
=========================================
  Files          13      14       +1     
  Lines        1039    1118      +79     
=========================================
+ Hits          524     587      +63     
- Misses        464     472       +8     
- Partials       51      59       +8
Impacted Files Coverage Δ
security/tls.go 79.74% <79.74%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f726eb9...e78f37e. Read the comment docs.

@michelvocks
Copy link
Member Author

@Skarlso added tests.

@Skarlso
Copy link
Member

Skarlso commented Jul 23, 2018

Awesome! <3

Copy link
Member

@Skarlso Skarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! :)

@michelvocks michelvocks merged commit 17b7873 into gaia-pipeline:master Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants