Refactored security package #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 53.59% 53.61% +0.01%
==========================================
Files 14 14
Lines 1196 1218 +22
==========================================
+ Hits 641 653 +12
- Misses 491 496 +5
- Partials 64 69 +5
Continue to review full report at Codecov.
|
Skarlso
reviewed
Jul 25, 2018
security/ca.go
Outdated
| } | ||
|
|
||
| // Both exist, skip | ||
| if certExist && keyExist { |
There was a problem hiding this comment.
This shloud be simplified to
_, certErr := os.Stat(c.caCertPath)
_, certPathErr := os.Stat(c.caKeyPath)
if certErr == nil && certPathErr == nil {
return
}
security/ca.go
Outdated
| if err := os.Remove(crt); err != nil { | ||
| return err | ||
| } | ||
| return os.Remove(key) | ||
| } | ||
|
|
||
| // GetCACertPath returns the path to the cert from the root CA. |
There was a problem hiding this comment.
Isn't the comment wrong here? It also returns the key's path.
michelvocks
force-pushed
the
security_refactored
branch
from
d99713c to
66bac0f
Compare
|
Good points @Skarlso 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored security package. Currently, the CA will be initiated and not used.
Ping @Skarlso