Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java support #60

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Java support #60

merged 1 commit into from
Aug 1, 2018

Conversation

michelvocks
Copy link
Member

@michelvocks michelvocks commented Jul 26, 2018

First implementation of Java support in Gaia. Fixes #42

TODO:

  • Find java executable dynamically.
  • Add build support.
  • Write tests.
  • Improve/Cleanup SDK a bit.

@codecov-io
Copy link

codecov-io commented Jul 26, 2018

Codecov Report

Merging #60 into master will decrease coverage by 2.5%.
The diff coverage is 51.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   55.88%   53.38%   -2.51%     
==========================================
  Files          16       14       -2     
  Lines        1419     1242     -177     
==========================================
- Hits          793      663     -130     
+ Misses        531      507      -24     
+ Partials       95       72      -23
Impacted Files Coverage Δ
pipeline/ticker.go 0% <0%> (ø) ⬆️
scheduler/scheduler.go 64.64% <40%> (-1.08%) ⬇️
security/ca.go 72.41% <64.7%> (-3.83%) ⬇️
handlers/handler.go 83.58% <0%> (-0.93%) ⬇️
security/vault.go
handlers/vault.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a905f4...c37a562. Read the comment docs.

@michelvocks michelvocks self-assigned this Jul 26, 2018
@michelvocks
Copy link
Member Author

Almost done. 🎉 🎊

Need to fix a test which is failing because maven is missing in the integration test container.

@michelvocks michelvocks requested a review from Skarlso July 30, 2018 18:27
@michelvocks michelvocks changed the title [WIP] Java support Java support Jul 30, 2018
@michelvocks
Copy link
Member Author

@Skarlso I will track documentation in a separate issue (#65). Please have a look 🤗

@michelvocks michelvocks added the Ready To Merge PR is ready to be merged into master label Jul 30, 2018
@Skarlso
Copy link
Member

Skarlso commented Jul 31, 2018

Will do today. :)

@Skarlso Skarlso merged commit ac87e63 into gaia-pipeline:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge PR is ready to be merged into master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants