-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline parameters #71
Pipeline parameters #71
Conversation
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
=========================================
+ Coverage 63.52% 63.72% +0.2%
=========================================
Files 19 19
Lines 1653 1668 +15
=========================================
+ Hits 1050 1063 +13
- Misses 492 495 +3
+ Partials 111 110 -1
Continue to review full report at Codecov.
|
ping @Skarlso |
Excellent! Looks good on a first run, I'll give it a manual. :) |
So, unfortunately I ran into a couple of problems @michelvocks. :/ I created two pipelines with the same repository. Once I set values to one, the other just flashed in the argument window and then puff, made it disappear immediately and went on running the pipeline. It came out as empty value in the logs. Second, the variables aren't cleared after once specifying them. Meaning, once you defined them, you can't every define them again, because they are already saved in cache I think, and so the asking module just flashes in and then immediately disappears. The Vault stuff is working nicely however. :) |
Oh thanks for the report. Let me try to reproduce and fix it 🤗 |
0f5a8fc
to
3ad38e2
Compare
@Skarlso I rebased and fixed your reported bugs. Try it again and let me know 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work buddy! :)
Fixes #24