Implemented python support #78
Conversation
michelvocks
added
the
Needs Work
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 63.84% 64.07% +0.22%
==========================================
Files 19 21 +2
Lines 1668 1751 +83
==========================================
+ Hits 1065 1122 +57
- Misses 493 512 +19
- Partials 110 117 +7
Continue to review full report at Codecov.
|
michelvocks
added
Ready To Merge
michelvocks
changed the title
|
@Skarlso This should be fine like it is. This was a bit more complicated compared to go and java and I had to add some extra stuff like extracting the pipelines in their own virtual environment. Also have a look at the SDK if you want: https://github.com/gaia-pipeline/pythonsdk |
| } | ||
|
|
||
| // install plugin in this environment | ||
| cmd = exec.Command("/bin/sh", "-c", fmt.Sprintf(pythonPipInstallCmd, filepath.Join(virtualEnvPath, p.Name))) |
There was a problem hiding this comment.
Uh. This will make supporting windows harder.
There was a problem hiding this comment.
True. I guess we have to add later a decision making here: e.g. if windows do this otherwise use this.
| // Build start command | ||
| c.Path = "/bin/sh" | ||
| c.Args = []string{ | ||
| "/bin/sh", |
There was a problem hiding this comment.
This too.
Not a blocker for now, but we might want to start thinking about abstracting this.
Even if you put it into a function to compartmentalise it, it will be easier to change later? Cause it's on place only.
There was a problem hiding this comment.
I think we can refactor this later. I don't want to hold back the new release because of this 🤗
| @@ -204,7 +203,7 @@ func (c *CA) CreateSignedCert() (string, string, error) { | |||
| } | |||
|
|
|||
| // Write out key file in PKCS#8 format | |||
| privateKey, err := marshalPKCS8PrivateKey(priv) | |||
| privateKey, err := x509.MarshalPKCS8PrivateKey(priv) | |||
Fixes #68
This feature will set the minimum golang version to 1.10 because I had to switch to
x509.MarshalPKCS8PrivateKeywhich was introduced with go 1.10.