Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show notification when create pipeline process is successfully triggered #83

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

bidhan-a
Copy link
Contributor

Related to #75

@codecov-io
Copy link

Codecov Report

Merging #83 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #83     +/-   ##
=========================================
+ Coverage   64.38%   64.48%   +0.1%     
=========================================
  Files          22       22             
  Lines        1881     1881             
=========================================
+ Hits         1211     1213      +2     
  Misses        537      537             
+ Partials      133      131      -2
Impacted Files Coverage Δ
scheduler/scheduler.go 74.08% <0%> (-0.73%) ⬇️
security/vault.go 76.69% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30593e8...d7a5ee4. Read the comment docs.

@michelvocks
Copy link
Member

Thanks a lot @bidhan-a 🤗 Let me test your PR 😄

Copy link
Member

@michelvocks michelvocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤗 Thanks a lot ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants