Log new object versions immediately after creation #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gaia_ptr_t::create()andgaia_ptr_t::update_payload()had a bug introduced when the autoconnect feature was added: the version just created would have its old offset saved but was logged after the autoconnect logic had executed, with the saved offset. If the autoconnect logic had created a new version, this would end up logging another version with the same "new" version (the one created by autoconnect), but using the "old" version corresponding to the offset saved before the original updated version was created. Therefore, the txn log contained two versions with the same "new" version but different "old" versions, which manifested as an attempted double-free (due to the duplicated "new" version), which was caught by an assert added in #889. That assert fired in the SDK testtest_connect_disconnect.disconnect_delete(https://gaiaplatform.atlassian.net/browse/GAIAPLAT-1501), and also in a test run of theamr_swarmapp (https://gaiaplatform.atlassian.net/browse/GAIAPLAT-1518).