Delete all table records when dropping tables #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuan
requested review from
senderista,
LaurentiuCristofor,
simone-gaia and
yiwen-wong
senderista
reviewed
Oct 24, 2021
simone-gaia
reviewed
Oct 24, 2021
|
|
||
| begin_transaction(); | ||
| gaia::addr_book::customer_t::delete_row(customer_id); | ||
| EXPECT_EQ(gaia::addr_book::customer_t::list().size(), 0); |
There was a problem hiding this comment.
Should this call fail? Maybe not as part of this PR, and maybe it makes sense it does not fail, just worth thinking about it. If we think this should fail you can add a follow up jira.
There was a problem hiding this comment.
I have created GAIAPLAT-1623 and added some comments.
senderista
approved these changes
Oct 24, 2021
chuan
force-pushed
the
chuan/drop-table
branch
from
239b4a7 to
9df9b18
Compare
chuan
force-pushed
the
chuan/drop-table
branch
from
9df9b18 to
1f8d57a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete the table records when dropping tables. The server side index logic needs to be updated due to table record and catalog info are updated in the same txn. I also moved the
resetmethod ingaia_ptrfrom protected to public.