Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gaiac crash error #1039

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Fix gaiac crash error #1039

merged 1 commit into from
Oct 27, 2021

Conversation

chuan
Copy link
Contributor

@chuan chuan commented Oct 27, 2021

Fix the gaiac crash described in the following JIRA:
https://gaiaplatform.atlassian.net/browse/GAIAPLAT-1564

@senderista
Copy link
Contributor

This is another example of why I think an RAII session wrapper analogous to auto_transaction_t would be useful (I proposed this to @daxhaw before but he didn't think that a lexically scoped session object would be very useful, since sessions are usually not confined to a single lexical scope).

@chuan chuan merged commit 686bd7c into master Oct 27, 2021
@chuan chuan deleted the chuan/gaiac-fix branch October 27, 2021 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senderista senderista senderista approved these changes

@LaurentiuCristofor LaurentiuCristofor Awaiting requested review from LaurentiuCristofor

@simone-gaia simone-gaia Awaiting requested review from simone-gaia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chuan @senderista