-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GAIAPLAT-1614 : Final changes required for measuring performance with Palletbox. #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackAtGaia
commented
Oct 27, 2021
- Adding palletbox-perf suite and tweaking workloads to make it work cleanly
- Small cleanup in scripts to make things look nicer
- Readding support for dumping database state so can output final state.
… at moving palletbox into template.
… comments to this codebase.
…er lint from swarm project.
… around to allow it to be templated.
…s to add performance measuring.
simone-gaia
reviewed
Oct 27, 2021
production/tests/workloads/palletbox/tests/perf/expected_output.json
Outdated
Show resolved
Hide resolved
production/tests/workloads/palletbox/tests/smoke/expected_output.json
Outdated
Show resolved
Hide resolved
LaurentiuCristofor
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just left comments and suggestions on a few minor issues.
…to LC and SR comments.
LGTM! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.