Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake EXPORT_SYMBOLS option and enable for FDW build #1053

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

senderista
Copy link
Contributor

This is kind of a hack, and I didn't try to understand exactly which symbols needed to be exported for the FDW to work, but at least it's not intrusive on the FDW itself at all.

The FDW tests still fail, but at least the FDW lib is loaded successfully:

sudo -u postgres psql
postgres=# create extension gaia_fdw;
ERROR:  Error opening COW-SE session.
HINT:  Exception: 'Connect failed! - Connection refused'.

Copy link
Contributor

@LaurentiuCristofor LaurentiuCristofor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Copy link
Contributor

@simone-gaia simone-gaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@senderista senderista merged commit cfd43f6 into master Nov 2, 2021
@senderista senderista deleted the tobin/fix_fdw_symbols branch November 2, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants