Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize references to Direct Access #1056

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

LaurentiuCristofor
Copy link
Contributor

Just fixed a message reference and corresponding unit tests, and some comments and README.md files.

Copy link
Contributor

@simone-gaia simone-gaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are some other places where Direct Access is spelled lower case:

  • catalog.hpp
  • type_cache.hpp
  • edc_base.hpp
  • A bunch of tests

Maybe you left them out on purpose. In case it was;t intentional you can use this to find all the occurrences in production (likely VS Code has some way to do this):

 grep -r -I -n "direct access" production | grep -v build

@LaurentiuCristofor
Copy link
Contributor Author

LGTM. There are some other places where Direct Access is spelled lower case:

* catalog.hpp

* type_cache.hpp

* edc_base.hpp

* A bunch of tests

Maybe you left them out on purpose. In case it was;t intentional you can use this to find all the occurrences in production (likely VS Code has some way to do this):

 grep -r -I -n "direct access" production | grep -v build

Thanks! I've seen them - I did a grep too. Most of them seem to use "direct access" literally, so I didn't bother changing them.

Really, the only reference I needed to change was the one in the message. But I thought it would help if I also fixed the references in some MD files and in the cmake files that we ship.

@LaurentiuCristofor LaurentiuCristofor merged commit 65b7d6d into master Nov 2, 2021
@LaurentiuCristofor LaurentiuCristofor deleted the laur_direct_access branch November 2, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants