Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDK break #1083

Merged
merged 1 commit into from
Nov 13, 2021
Merged

Fix SDK break #1083

merged 1 commit into from
Nov 13, 2021

Conversation

LaurentiuCristofor
Copy link
Contributor

Forgot to make the new int_type_t header API visible.

Copy link
Contributor

@senderista senderista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really annoying that this is still a manual step that's easy to forget. I'll create a JIRA for automating the pragma insertion or something equivalent. I don't have any ideas yet that I really like, but hopefully we'll think of something better eventually.

Copy link
Contributor

@daxhaw daxhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also totally forgot about this!

@daxhaw
Copy link
Contributor

daxhaw commented Nov 13, 2021

It's really annoying that this is still a manual step that's easy to forget. I'll create a JIRA for automating the pragma insertion or something equivalent. I don't have any ideas yet that I really like, but hopefully we'll think of something better eventually.

@senderista : I really do like having to explicitly say that these symbols are public.

@senderista
Copy link
Contributor

@senderista : I really do like having to explicitly say that these symbols are public.

OK, I was just thinking that any headers in a "public" dir would automatically have their symbols exported. Is that too magical for you?

@LaurentiuCristofor LaurentiuCristofor merged commit 43e90da into master Nov 13, 2021
@LaurentiuCristofor LaurentiuCristofor deleted the laur_sdk_fix branch November 13, 2021 19:12
@simone-gaia
Copy link
Contributor

It's really annoying that this is still a manual step that's easy to forget. I'll create a JIRA for automating the pragma insertion or something equivalent. I don't have any ideas yet that I really like, but hopefully we'll think of something better eventually.

The simplest thing to do is to have the pre-commit hook fail if the pragma is not found in the public headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants