GAIAPLAT-1721 : Adding memory sampling support to framework. #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackAtGaia
requested review from
JWhitleyWork,
senderista,
simone-gaia and
stevegaia
LaurentiuCristofor
approved these changes
Nov 19, 2021
| # Clean entrance into the script. | ||
| start_process | ||
|
|
||
| if [ $SHOW_MODE -ne 0 ] ; then | ||
| echo "Installed DEB pacakage as follows:" |
| @@ -10,15 +10,18 @@ SCRIPTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )" | |||
|
|
|||
| # Set up any project based local script variables. | |||
| # | |||
| # Note that these three variables, SUITE_MODE, TEST_WORKLOADS, and USE_PERSISTENT_DATABASE | |||
| # are used within the sourced script. To keep shellcheck happy, we disable them. | |||
| # Note that these four variables, SUITE_MODE, TEST_WORKLOADS, USE_PERSISTENT_DATABASE, | |||
There was a problem hiding this comment.
Maybe stop counting the variables so that you don't have to change the first line with every addition.
|
|
||
| if [ -n "$DB_SERVER_PID" ] ; then | ||
| if [ "$VERBOSE_MODE" -ne 0 ]; then | ||
| echo "Killing started database server." |
There was a problem hiding this comment.
This reads funny. Did the killing start the database server? Was it meant to be "Killing the started database server" or simply: "Killing the database server" because nobody expects you'd be killing a non-started server.
| # shellcheck disable=SC2181 | ||
| if [ $? -ne 0 ] ; then | ||
| cat "$MEMORY_LOG_FILE" | ||
| complete_process 1 "Cannot start the database memory monitoring." |
There was a problem hiding this comment.
This style reminds me of German, with the verb at the end. I think it would read a bit more clearly if we'd said: "Cannot start the monitoring of the database memory".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gaiaplatform.atlassian.net/browse/GAIAPLAT-1721
Part of tracking performance is being able to track memory usage over an extended period of time. This work uses a "custom" ps_mem.py script to try and get a decent picture of what that memory usage looks like for the gaia_db_server application.
Note that the use of ps_mem.py is a first step, and I am open to adding in other memory sampling scripts after this has been tested and we have a good idea of where any pitfalls of this script are.
Note that some of this work overlaps with: #1075 regarding aggregating test suites and adding database support to the scripts.