[GAIAPLAT-1024] get_txn_id() is redundant once get_current_txn_id() is implemented #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senderista
approved these changes
Nov 22, 2021
| gaia_txn_id_t get_txn_id(); | ||
| * Internal API for getting the begin_ts of the current txn. | ||
| */ | ||
| gaia_txn_id_t get_current_txn_id(); |
There was a problem hiding this comment.
We need to straighten out the header dependencies here. It doesn't make any sense that this header is included by the db_server library, which isn't supposed to know about the db_client library, given that the implementation calls into the db_client library! I'm not even sure how this is linking, but I guess that the db_server library must have some transitive link dependency on the db_client library that isn't obvious. Regardless, it doesn't make sense for the server to include a header with an interface whose implementation it shouldn't be linking. Let's address this in a future PR.
There was a problem hiding this comment.
LaurentiuCristofor
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the client-only get_txn_id() method and switched all uses get_current_txn_id()