Reorganize public rules headers

[LaurentiuCristofor]

Discussed these changes with Dax. They make it so that the rules.hpp header is the main one that needs to be included.

[daxhaw]

The only other file I changed was event_manager.hpp. This was including gaia/rules/exceptions.hpp instead of gaia/rules/rules.hpp. Other than that, this looks good. Thank you!

[LaurentiuCristofor]

The only other file I changed was event_manager.hpp. This was including gaia/rules/exceptions.hpp instead of gaia/rules/rules.hpp. Other than that, this looks good. Thank you!

Given that that is an internal header, do you want it to include more than it needs to? It only needs the exceptions definitions because it initializes an invalid_rule_binding. If we'd move that code to the .cpp, we probably wouldn't even need to include that file. I try to keep internal headers light, so that we only pull the definitions we need.

[LaurentiuCristofor]

The only other file I changed was event_manager.hpp. This was including gaia/rules/exceptions.hpp instead of gaia/rules/rules.hpp. Other than that, this looks good. Thank you!

Given that that is an internal header, do you want it to include more than it needs to? It only needs the exceptions definitions because it initializes an invalid_rule_binding. If we'd move that code to the .cpp, we probably wouldn't even need to include that file. I try to keep internal headers light, so that we only pull the definitions we need.

OTOH, we may already include rules.hpp through the other internal headers, in which case I can remove the public include completely. Let me try that.

[daxhaw]

Looks good! Thanks.