[GAIAPLAT-1808] Remove VLR code from direct_access example #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this impact the existing documentation? |
Do we refer to VLR in the existing documentation? If we are OK with this change we should amend the documentation too. If we manage to get the VLR example in for Preview.2 the documentation may remain unchanged., |
chuan
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was checking the
direct_accessexample after @daxhaw suggestion and it turns out is broken because of the latest VLR changes.I have removed the VLR code from the example because I believe it deserves its own example. Created follow-up task for it: https://gaiaplatform.atlassian.net/browse/GAIAPLAT-1809
lookup_invalid_record()