Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull rocksdb arm64 fix #1135

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Pull rocksdb arm64 fix #1135

merged 1 commit into from
Dec 14, 2021

Conversation

mihirj1993
Copy link

@mihirj1993 mihirj1993 commented Dec 14, 2021 •
edited
Loading

senderista
senderista approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@senderista senderista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we already have a JIRA about un-forking RocksDB to prevent issues already fixed in upstream from affecting us, or do you think there are still good reasons to maintain our own fork?

@mihirj1993 mihirj1993 merged commit 301f189 into master Dec 14, 2021
@mihirj1993 mihirj1993 deleted the arm_fix branch December 14, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senderista senderista senderista approved these changes

@simone-gaia simone-gaia Awaiting requested review from simone-gaia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mihirj1993 @senderista