Fix test_db.py failure caused by gaia_ptr_t refactoring #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simone-gaia
requested review from
senderista,
LaurentiuCristofor,
daxhaw and
chuan
senderista
reviewed
Dec 14, 2021
| @@ -3,36 +3,36 @@ | |||
| # All rights reserved. | |||
| ############################################# | |||
|
|
|||
| from gaia_db_pybind import *; | |||
senderista
approved these changes
Dec 14, 2021
JackAtGaia
reviewed
Dec 14, 2021
production/db/core/src/dump_se.py
Outdated
| type = 1; | ||
| done = False; | ||
| type = 1 | ||
| done = False | ||
| while not(done): |
JackAtGaia
reviewed
Dec 14, 2021
|
|
||
| print("Iterating through nodes of type: " + str(type) + "..."); | ||
| node_iter = gaia_ptr.find_first(type); | ||
| print("Iterating through nodes of type: " + str(type) + "...") |
There was a problem hiding this comment.
personally, I would use f-strings if you are comfortable with them.
There was a problem hiding this comment.
I can;t compile/run this thing locally so I would refrain from that. (otherwise I would)
JackAtGaia
reviewed
Dec 14, 2021
production/db/core/src/dump_se.py
Outdated
| print("Iterating through nodes of type: " + str(type) + "..."); | ||
| node_iter = gaia_ptr.find_first(type); | ||
| print("Iterating through nodes of type: " + str(type) + "...") | ||
| node_iter = gaia_ptr.find_first(type) | ||
|
|
||
| if (node_iter.is_null() == True): |
JackAtGaia
reviewed
Dec 14, 2021
production/db/core/src/dump_se.py
Outdated
| print("No nodes of type " + str(type) + " were found!"); | ||
| no_node = True; | ||
| print("No nodes of type " + str(type) + " were found!") | ||
| no_node = True | ||
|
|
||
| while node_iter.is_null() != True: |
JackAtGaia
reviewed
Dec 14, 2021
|
|
||
| type = type + 1; |
JackAtGaia
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gaia_ptr_t::opentogaia_ptr_t::from-gaia_id();Note: I haven't been able to build the python stuff on my machine for a while. Running a CI build to see if this is actually working: