GAIAPLAT-2070 - Adding coverage support to docker_dev #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions more evident.
… into gaiaplat-2066
…kage after lifting out Abort exception. https://gaiaplatform.atlassian.net/browse/GAIAPLAT-2067
JackAtGaia
requested review from
LaurentiuCristofor,
phillipov,
senderista and
simone-gaia
| def __repr__ | ||
| if self\.debug | ||
|
|
||
| # Don't complain if tests don't hit defensive assertion code: |
There was a problem hiding this comment.
I suspect that this does not cover our own assertions, which means that our coverage numbers will be lower than they would be without assertions. If that's the case, perhaps we could run coverage on code built with assertions disabled?
Just brainstorming here. Whatever good ideas come from this, we should track them in JIRA.
There was a problem hiding this comment.
This is just the standard boilerplate for coverage.
LaurentiuCristofor
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gaiaplatform.atlassian.net/browse/GAIAPLAT-2070
Adding the reporting of coverage. Currently at 86%.