Cleanup: Switch evaluate_operator to constexpr inline instead of static where possible #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,13 +20,13 @@ namespace expressions | |||
| { | |||
|
|
|||
| // == operator. | |||
| static inline bool evaluate_operator(common::gaia_id_t left, common::gaia_id_t right, operator_eq_t) | |||
| constexpr inline bool evaluate_operator(common::gaia_id_t left, common::gaia_id_t right, operator_eq_t) | |||
There was a problem hiding this comment.
I'd put inline before constexpr, because I feel that constexpr is a more essential part of the declaration, so we shouldn't insert "inline" in the middle of it.
LaurentiuCristofor
approved these changes
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the compiler a little happier and stop generating unnecessary symbols.