Gaiaplat 2086 - Cleaning up coverage job. #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackAtGaia
requested review from
LaurentiuCristofor,
phillipov,
senderista,
simone-gaia and
stevegaia
daxhaw
reviewed
Mar 3, 2022
| @@ -172,6 +172,12 @@ if [ -n "$BASE_IMAGE" ] ; then | |||
| COVERAGE_IMAGE_BASE="--cache-from $BASE_IMAGE" | |||
| fi | |||
|
|
|||
| echo "--" | |||
There was a problem hiding this comment.
Just debug spew or do you intend to keep this in there?
There was a problem hiding this comment.
I would like to keep that in there for a week or so until we can make sure that these changes are consistently working. if they fail, those should give me extra debug information
daxhaw
reviewed
Mar 3, 2022
production/coverage/gen_coverage.sh
Outdated
| rm -rf llvm/unittests/ | ||
| rm -rf llvm/tools/ | ||
| rm -rf llvm/test/ | ||
| #rm -rf llvm/lib/*.a |
There was a problem hiding this comment.
Remove unused remove commands?
daxhaw
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gaiaplatform.atlassian.net/browse/GAIAPLAT-2086