Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve VLR insertion performance tests #1422

Merged
merged 3 commits into from
Mar 23, 2022
Merged

Improve VLR insertion performance tests #1422

merged 3 commits into from
Mar 23, 2022

Conversation

simone-gaia
Copy link
Contributor

  1. Split up VLR tests into different tests to better measure performance
  2. Improve the reporting of the log_performance_difference method. New format: 
    [value_linked_relationships_autoconnect_to_different_parent] 2000 rows, 5 iterations:
  [total]: avg:2690.39ms min:2621.76ms max:2792.13ms
 [single]: avg:1345.19us min:1310.88us max:1396.07us
  3. Remove narrowing conversion warnings.

LaurentiuCristofor
LaurentiuCristofor reviewed Mar 23, 2022
View reviewed changes
production/direct_access/tests/test_insertion_perf.cpp Outdated
// finish in a reasonable amount of time.
constexpr uint64_t c_vlr_insertions = c_num_insertion / 50;

auto insert6 = []() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this called insert6?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we forget to increment the counter in the name? I think we should drop it entirely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove.

stevegaia
stevegaia approved these changes Mar 23, 2022
View reviewed changes
Copy link

@stevegaia stevegaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simone-gaia simone-gaia merged commit 7b2bcfc into master Mar 23, 2022
@simone-gaia simone-gaia deleted the rondelli-imporve-vlr-insert-tests branch March 23, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurentiuCristofor LaurentiuCristofor LaurentiuCristofor approved these changes

@stevegaia stevegaia stevegaia approved these changes

@senderista senderista Awaiting requested review from senderista

@daxhaw daxhaw Awaiting requested review from daxhaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simone-gaia @LaurentiuCristofor @stevegaia