Skip server-only processing in client calls to update_indexes_from_txn_log() #1430
Conversation
| @@ -7,6 +7,9 @@ | |||
| #include "db_helpers.hpp" | |||
| #include "db_shared_data.hpp" | |||
|
|
|||
| const bool gaia::db::c_is_running_on_server = false; | |||
There was a problem hiding this comment.
Can these be constexpr, or not?
There was a problem hiding this comment.
I'm not sure. I assumed not, because they're extern, but I didn't try - I'll try now...
There was a problem hiding this comment.
It doesn't work:
error: constexpr variable declaration must be a definition
Given that we need to separate the definition from the declaration, we need to go with const.
Yes, I don't have something just for client right now. I've just excluded some unnecessary checks from being done on the client. The next change may involve some client-only changes, but they'll probably depend on other client-side variables, so I may not have to use the new booleans. BTW, I added two of them, just to avoid having to deal with negations. |
LaurentiuCristofor
force-pushed
the
laur_client_server
branch
from
d53ea8f to
5ea20ca
Compare
Also added two constants to simplify checks about whether code is executed on server or client and re-formatted some long lines in the touched files.