Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary calls to register_type() #1431

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Avoid unnecessary calls to register_type() #1431

merged 2 commits into from
Mar 25, 2022

Conversation

senderista
Copy link
Contributor

This improves insert throughput from 0.59 to 0.55us/insert for test_insert_perf.simple_table_insert with 100M records.

simone-gaia
simone-gaia approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@simone-gaia simone-gaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@senderista senderista merged commit 54a4626 into master Mar 25, 2022
@senderista senderista deleted the tobin/fix_register_type branch March 25, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurentiuCristofor LaurentiuCristofor LaurentiuCristofor approved these changes

@simone-gaia simone-gaia simone-gaia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@senderista @LaurentiuCristofor @simone-gaia