-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use minimal TLS implementation for thread-local mapping objects #1500
Changes from 30 commits
fb8f792
1756132
b6f0b11
96d8225
0f34ad9
8f28333
67a34b3
514528a
1f39745
9eb5e85
dee200d
7156f32
0a3c62b
40ec16b
6fcb684
426c29e
e59314f
1b6b614
1532617
e2c2413
aaf0297
f026272
75d56df
48a72ae
3c1a12f
ae8056e
6d47632
30f5301
4cc343e
9acde99
e741a29
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,18 +3,6 @@ | |
// All rights reserved. | ||
///////////////////////////////////////////// | ||
|
||
template <typename T_data> | ||
core_mapped_data_t<T_data>::core_mapped_data_t() | ||
{ | ||
clear(); | ||
} | ||
|
||
template <typename T_data> | ||
core_mapped_data_t<T_data>::~core_mapped_data_t() | ||
{ | ||
close_internal(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, and I don't remember - how do we call this now - where is this cleanup being done after this change? Is it through the We should also add an explicit comment to this class that the cleanup is manual and no longer automatic. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, all cleanup is being done through There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In violation of my stated goal of minimal changes to the data mapping classes, I went ahead and removed the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I'm not sure if there is much refactoring that can be done here. That's what I noticed also, when I took a closer look - that the hierarchy was needed for the
Right. Thanks! It's a fairly small change and I think it helps to remove these "internal" helpers when they're no longer needed. |
||
} | ||
|
||
template <typename T_data> | ||
void core_mapped_data_t<T_data>::clear() | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean? Were all asserts disabled or just specific ones (the ones recently converted to debug)? Also, what was the gain without disabling any new asserts?
If there is a great gain from disabling asserts, which asserts accounted for it (i,e, which ones would be good candidates for being changed into debug asserts)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disabled all asserts to help determine the magnitude of performance improvements (because assertion overhead will tend to dilute perf gains). Of course asserts were disabled in the baseline (master) as well, if you were wondering. I haven't measured with asserts enabled.