Remove duplicated copy of test_perf.hpp #1508
Conversation
| using namespace gaia::common; | ||
| using namespace gaia::direct_access; | ||
| using namespace gaia::perf_basic; |
There was a problem hiding this comment.
Shouldn't this namespace (and similar) be under gaia::benchmark?
There was a problem hiding this comment.
This is the DAC namespace.
There was a problem hiding this comment.
@simone-gaia is right. I don't think there is a way to shove in a benchmark name in there. The namespace seems to be derived from the database name.
| @@ -106,7 +112,7 @@ class accumulator_t | |||
|
|
|||
| double_t percentage_difference(size_t expr, size_t plain) | |||
| { | |||
| return static_cast<double_t>(expr - plain) / static_cast<double_t>(plain) * 100.0; | |||
| return static_cast<double_t>(expr) - static_cast<double_t>(plain) / static_cast<double_t>(plain) * 100.0; | |||
There was a problem hiding this comment.
I think you need parentheses around the whole numerator. I would also add parentheses around the whole fraction itself to clarify that the factor 100 is multiplying the rest of the expression.
There was a problem hiding this comment.
I.e. ((static_cast<double_t>(expr) - static_cast<double_t>(plain)) / static_cast<double_t>(plain)) * 100.0
There was a problem hiding this comment.
Good points, good catch! I'll do this in next commit!
LaurentiuCristofor
force-pushed
the
laur_test_perf_dup
branch
from
32383a3 to
9b880f6
Compare
This ensures that we don't end up with diverging copies, as we make updates to these helpers.