-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove useless stuff #1525
Remove useless stuff #1525
Conversation
…into rodnelli-remove-pointless-stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the airport data is used to test the FDW, so if we want to remove it, we should also remove the main FDW test. I think we should leave this data in.
Ok, I'll put them back in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as long as FDW tests aren't broken (can we move some data into a test folder in that case?).
The files needed for the test are the gz files, but the graphml files are also interesting for someone that may want to work with graph data and were used at some point by the Java graph interface. If we don't want to keep them here, I can create a personal repository for the tool that generated them (which was in scratch) and store them there. |
If this data is only needed by the FDW tests, then should it be moved into a local folder instead of its current top-level location? |
I'm fine with doing that and removing the data folder. |
Delete the following folders:
data/
scratch/
third_party/evaluation/