Enable github action runners #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senderista
reviewed
May 24, 2022
senderista
reviewed
May 24, 2022
senderista
approved these changes
May 24, 2022
|
Thanks for the review @senderista |
| @@ -61,7 +61,7 @@ def get_base_stages_text(self) -> str: | |||
| """ | |||
|
|
|||
| base_stages_text = dedent( | |||
| fr""" | |||
There was a problem hiding this comment.
What is this change for?
There was a problem hiding this comment.
This string prefix was flagged as a lint error when I had to upgrade our version of black. The old version of black on the github action runners had a dependency such that we couldn't run the python linter and the fix was to upgrade to the latest version. (change is in .pre-commit-config.yaml).
There was a problem hiding this comment.
Thanks for the explanation! And what do these letters stand for, if they stand for anything?
There was a problem hiding this comment.
They designate "format" f and "raw" r strings in python. Here is an explanation.
LaurentiuCristofor
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we flip the repo from private to public, we can use github action runners instead of our own self-hosted ones. These changes enable running our jobs on the public runners.
PLEASE DO NOT MERGE UNTIL WE MOVE THE REPO FROM PRIVATE TO PUBLIC.