Allow to pass a declarative table reference to a function #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simone-gaia
reviewed
Mar 18, 2021
| const auto *id = record->getIdentifier(); | ||
| if (id != nullptr) | ||
| { | ||
| if (id->getName().equals(tableName + "_t")) |
There was a problem hiding this comment.
does this mean that now all anchor references are of type table_t? If so does this mean I can call any method exposed by table_t?
There was a problem hiding this comment.
Not sure what you mean by "I can call any method exposed by table_t"?
Are you referring to the parameter type, like "I can call any function similar to f(table_t)"?
There was a problem hiding this comment.
No you don't. I am not exposing methods of table_t type when you reference table in a rule. You can write f(table) and do inside the function whatever you want as function accepts real table_t type.
daxhaw
reviewed
Mar 18, 2021
| @@ -9518,4 +9518,6 @@ def err_invalid_rule_context_internal_error : Error< | |||
| "Internal error while generating 'rule_context'.">; | |||
| def err_invalid_rule_attribute : Error< | |||
| "Invalid Gaia rule attribute.">; | |||
| def err_ambiguous_field_name : Error< | |||
| "'%0' is ambiguous as both a table and a field with this name exist in the catalog.">; | |||
There was a problem hiding this comment.
"as"->"because"
daxhaw
approved these changes
Mar 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.