Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a potential memory leak in gaia parser #648

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Fix a potential memory leak in gaia parser #648

merged 1 commit into from
Apr 30, 2021

Conversation

chuan
Copy link
Contributor

@chuan chuan commented Apr 30, 2021

Use scope guard to clean up parser in case of exceptions.

@chuan chuan requested review from simone-gaia and senderista April 30, 2021 16:32
simone-gaia
simone-gaia approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@simone-gaia simone-gaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chuan chuan merged commit 80dac8b into master Apr 30, 2021
@chuan chuan deleted the fix-parsing-memory-leak branch April 30, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simone-gaia simone-gaia simone-gaia approved these changes

@senderista senderista Awaiting requested review from senderista

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chuan @simone-gaia