Language test refinements #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,7 +31,7 @@ class test_mixed_code : public db_catalog_test_base_t | |||
| { | |||
| public: | |||
| test_mixed_code() | |||
| : db_catalog_test_base_t("barn_storage.ddl"){}; | |||
| : db_catalog_test_base_t("incubator.ddl"){}; | |||
There was a problem hiding this comment.
I had fixed this test too - is this branch not up to date with master?
There was a problem hiding this comment.
Maybe not, but I'm the only one working on most of these files. I'll clean it up in the merge.
| int unsigned i = 0; | ||
| if (i == 0) | ||
| { | ||
| /F:farmer.acreage += 1; |
There was a problem hiding this comment.
What does /F: do?
There was a problem hiding this comment.
It defines a tag named "F" for subsequent use in this statement (but it isn't used). Since this test is for tag scoping, the subsequent use wasn't necessary for the test.
LaurentiuCristofor
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These updates accompany Gregory's PR #639. In addition to new tests, it should test cleanly in the TranslationEngineLLVM/clang/test/Parser directory.
Some tests are marked as (fixed) and are left for regression.
Converted the test files to a convention where tests that currently fail can be commented out so that the build will not fail because of a failed test. This should allow retesting when features have been added and bugs have been fixed.