Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAIAPLAT-946] Check for eof when skipping through a bad ruleset #685

Merged
merged 2 commits into from
May 27, 2021

Conversation

waynelwarren
Copy link
Contributor

Very small bug fix. Prevents infinite loop of gaiat when there is an ill-formed ruleset.

Copy link
Contributor

@simone-gaia simone-gaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nit: Can you add a regression test?

Copy link
Contributor

@simone-gaia simone-gaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@waynelwarren
Copy link
Contributor Author

Regression test was a good idea and easy. Thanks.

@waynelwarren waynelwarren merged commit d7929c2 into master May 27, 2021
@waynelwarren waynelwarren deleted the wayne/GAIAPLAT-946 branch May 27, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants