Enable LLD linker to enable UBSan #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senderista
requested review from
chuan,
LaurentiuCristofor,
daxhaw,
fineg74 and
simone-gaia
production/gdev.cfg
Outdated
| @@ -9,6 +9,7 @@ libcap-dev | |||
| openjdk-8-jdk | |||
| python3-dev | |||
| {enable_if('GaiaRelease')}rpm | |||
| lld | |||
There was a problem hiding this comment.
Maybe move this higher in this list, as it's a more important component than the others.
LaurentiuCristofor
approved these changes
Jun 5, 2021
simone-gaia
approved these changes
Jun 5, 2021
Sadly, I have no idea... |
senderista
added a commit
that referenced
this pull request
Jun 6, 2021
This reverts commit 02450dd.
senderista
added a commit
that referenced
this pull request
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of 3 atomic PRs to enable UBSan in our debug builds. The second will fix existing issues found by UBSan, and the third will enable UBSan in "immediate termination" mode, so builds with flagged issues will immediately fail the test suite.
NB: this requires
lldto be installed in the build environment.lldis now automatically installed bygdev, but in non-gdevenvironments, you need to install it with the OS package manager, e.g. on Ubuntu: